Skip to content

Make --strict-equality stricter with literals #7310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2019
Merged

Make --strict-equality stricter with literals #7310

merged 2 commits into from
Aug 9, 2019

Conversation

ilevkivskyi
Copy link
Member

Fixes #6672

A possible downside is that error messages may be scarier for new users, but on the other hand maybe more people will learn about Literal.

msullivan
msullivan approved these changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

@msullivan msullivan merged commit 4ff341f into python:master Aug 9, 2019
@ilevkivskyi ilevkivskyi deleted the strict-eq-literals branch August 9, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

@Michael0x2a Michael0x2a Awaiting requested review from Michael0x2a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--strict-equality should work with literal types
2 participants
@ilevkivskyi @msullivan